[PATCH] D44277: Avoid creating a Constant for each value in a ConstantDataSequential.

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 16:01:06 PST 2018


bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

Seems straightforward enough. LGTM.



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2130-2131
 static void emitGlobalConstantFP(const ConstantFP *CFP, AsmPrinter &AP);
+static void emitGlobalConstantFPFromAPFloat(APFloat APF, Type *ET,
+                                            AsmPrinter &AP);
 
----------------
I'm not sure the "FromAPFloat" adds much here, maybe we should just overload emitGlobalConstantFP?


Repository:
  rL LLVM

https://reviews.llvm.org/D44277





More information about the llvm-commits mailing list