[PATCH] D44177: [JumpThreading] use UnreachableBlocks to avoid unreachable regions

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 15:45:58 PST 2018


brzycki updated this revision to Diff 137665.
brzycki added a comment.

Addressed @kuhar 's comments.

@kuhar , I was incorrect about the `for (auto &BB : F)` causing crashes. It was actually the `ifdef NDEBUG` when I moved it into `JumpThreading.cpp`. I opted to not add an `NDEBUG` stanza and just use `SmallPtrSet`. There are several other instances of local pointer sets within JumpThreading that do the same.


https://reviews.llvm.org/D44177

Files:
  llvm/lib/Transforms/Scalar/JumpThreading.cpp
  llvm/test/Transforms/JumpThreading/pr15851_hang.ll
  llvm/test/Transforms/JumpThreading/select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44177.137665.patch
Type: text/x-patch
Size: 6561 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180308/940b3afa/attachment.bin>


More information about the llvm-commits mailing list