[PATCH] D44274: Object: Fix handling of @@@ in .symver directive

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 15:17:35 PST 2018

espindola added inline comments.

Comment at: llvm/lib/Object/RecordStreamer.cpp:151
 MCSymbol *RecordStreamer::createELFSymverAlias(StringRef AliasName,
                                                const MCSymbol *Aliasee) {
What version are you using? I don't see createELFSymverAlias on master.

Comment at: llvm/lib/Object/RecordStreamer.cpp:153
                                                const MCSymbol *Aliasee) {
-  // TODO: Handle "@@@". Depending on SymbolAttribute value it needs to be
-  // converted into @ or @@.
+  auto Split = AliasName.split("@@@");
+  SmallString<64> NewName;
Use an explicit type instead of auto.


More information about the llvm-commits mailing list