[PATCH] D44258: [ConstantFold] fp_binop undef, undef --> undef

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 09:56:58 PST 2018


spatel created this revision.
spatel added reviewers: arsenm, efriedma, andrew.w.kaylor, lattner.
Herald added subscribers: wdng, mcrosier.

I don't think there's any controversy about this case, and it seems independent of any LangRef edits (https://reviews.llvm.org/D44216).

I tried to fix tests that would fold away:
https://reviews.llvm.org/rL327004
https://reviews.llvm.org/rL327028
https://reviews.llvm.org/rL327030
https://reviews.llvm.org/rL327034

I'm not sure if the Reassociate tests are meaningless yet, but they probably will be as we add more folds, so if anyone has suggestions or wants to fix those, please do.


https://reviews.llvm.org/D44258

Files:
  lib/IR/ConstantFold.cpp
  test/Transforms/InstCombine/X86/X86FsubCmpCombine.ll
  test/Transforms/InstSimplify/fp-undef.ll
  test/Transforms/Reassociate/factorize-again.ll
  test/Transforms/Reassociate/fp-expr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44258.137594.patch
Type: text/x-patch
Size: 5852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180308/b5fdd3e8/attachment.bin>


More information about the llvm-commits mailing list