[PATCH] D44224: [llvm-objdump] Support disassembling by symbol name

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1420
+
+    static StringSet<> DisasmFuncsSet;
+    if (DisasmFuncsSet.empty() && !DisassembleFunctions.empty())
----------------
Not a big fan of having a static var here. How about extracting this into a function:

```
static StringSet<> GetDisasmFuncsSet() {
	static StringSet<> DisasmFuncsSet;
  if (DisasmFuncsSet.empty() && !DisassembleFunctions.empty())
    DisasmFuncsSet.insert(DisassembleFunctions.begin(),
                          DisassembleFunctions.end());
  return DisasmFuncsSet;
}
```


Repository:
  rL LLVM

https://reviews.llvm.org/D44224