[PATCH] D44249: [SelectionDAG] Handle big-endian target BITCAST in computeKnownBits()

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 06:44:11 PST 2018


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2381
       for (unsigned i = 0; i != SubScale; ++i) {
         computeKnownBits(N0, Known2, SubDemandedElts.shl(i),
                          Depth + 1);
----------------
Will this be correct? Does it need to be reversed for BE?
```
SubDemandedElts.shl(ISLE ? i : (SubScale - 1 - i))
```


https://reviews.llvm.org/D44249





More information about the llvm-commits mailing list