[PATCH] D43690: [ThinLTO] Keep available_externally symbols live

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with fixes noted below.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:557
+          AvailableExternally = true;
+        if (GlobalValue::isInterposableLinkage(S->linkage()))
+          Interposable = true;
----------------
else if can be used here.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:558
+        if (GlobalValue::isInterposableLinkage(S->linkage()))
+          Interposable = true;
+      }
----------------
This is only used in the assert, so I suspect you will need to guard with #ifndef NDEBUG to avoid a warning about unused variable.


Repository:
  rL LLVM

https://reviews.llvm.org/D43690