[PATCH] D44202: [DebugInfo/AccelTable] Fix inconsistency in getDIEOffset implementations

[Pavel Labath via Phabricator via llvm-commits]

labath updated this revision to Diff 137560.
labath added a comment.

- Add the DIEOffsetBase only for the DW_FORM_ref*** family. There's a function in DWARFFormValue that could be of use for this, but it assumes you have the entire DWARFUnit around, and not just it's offset. As it stands now, I just hard-code the list of forms and perform the addition manually.
- Treat CU and die offsets identically.


Repository:
  rL LLVM

https://reviews.llvm.org/D44202

Files:
  include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
  lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
  test/tools/llvm-dwarfdump/X86/apple-names-die-offset-data.s
  test/tools/llvm-dwarfdump/X86/apple-names-die-offset-ref.s
  test/tools/llvm-dwarfdump/X86/debug-names-find.s
  tools/llvm-dwarfdump/llvm-dwarfdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44202.137560.patch
Type: text/x-patch
Size: 14298 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180308/a2b112ff/attachment.bin>