[PATCH] D44244: [LLVM] Add -git-commit-after-all option

Hongbin Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 21:37:27 PST 2018


etherzhhb added inline comments.


================
Comment at: include/llvm/IR/GitCommitModule.h:32-33
+///
+/// Note: This pass is for use with the new pass manager. Use the create...Pass
+/// functions above to create passes for use with the legacy pass manager.
+class GitCommitModulePass {
----------------
there is no create...Pass


================
Comment at: lib/IR/LegacyPassManager.cpp:739-740
+    // TODO Use the pass options as commit message instead
+    Pass *PP = P->createGitCommitModulePass(GitRepo, P->getPassName());
+    if (PP)
+      PP->assignPassManager(activeStack, getTopLevelPassManagerType());
----------------
```
    if (auto *PP = P->createGitCommitModulePass(GitRepo, P->getPassName()))
```


Repository:
  rL LLVM

https://reviews.llvm.org/D44244





More information about the llvm-commits mailing list