[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp marked an inline comment as done.
wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:100
     case dwarf::DW_RLE_end_of_list:
+      CurrentRanges.emplace_back(RangeListEntry{EntryOffset, Encoding});
       Ranges.insert(Ranges.end(), CurrentRanges);
----------------
dblaikie wrote:
> It's probably better to use push_back rather than emplace_back, if both are valid. (they'll be both as efficient, but emplace_back can do explicit conversions where push_back can only do implicit conversions - so it's simpler, there's less "going on")
Didn't update the review but I'm making this change before I commit.


https://reviews.llvm.org/D43366