[PATCH] D44193: [ELF] - Fix crash relative to SHF_LINK_ORDER sections.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> Index: ELF/OutputSections.cpp
> ===================================================================
> --- ELF/OutputSections.cpp
> +++ ELF/OutputSections.cpp
> @@ -100,7 +100,8 @@
>      Flags = IS->Flags;
>    } else {
>      // Otherwise, check if new type or flags are compatible with existing ones.
> -    if ((Flags & (SHF_ALLOC | SHF_TLS)) != (IS->Flags & (SHF_ALLOC | SHF_TLS)))
> +    if ((Flags & (SHF_ALLOC | SHF_TLS | SHF_LINK_ORDER)) !=
> +        (IS->Flags & (SHF_ALLOC | SHF_TLS | SHF_LINK_ORDER)))

Please move SHF_ALLOC | SHF_TLS | SHF_LINK_ORDER to a mask variable.

LGTM with that.

Cheers,
Rafael