[PATCH] D44180: Improve --warn-symbol-ordering.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 09:05:37 PST 2018


ruiu added a comment.

I don't want to do stuff that is too clever, and I'm OK in either warning on it and don't sort, or don't warn on it and do sort. I just want to fix the issue that we currently tell user that the section is ignored but actually be sorted.

To keep things simple, I'd suggest we do warn on ICF'ed functions and skip them when we see them in the loop. Does this sound OK?


https://reviews.llvm.org/D44180





More information about the llvm-commits mailing list