[PATCH] D44211: DWARFVerifier: Basic verification of .debug_names

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 08:49:06 PST 2018


JDevlieghere added a comment.

I think you can be generous with the levels. I see a note more as a thing that follows a warning or an error with some more context, rather than a statement by itself.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFVerifier.h:241
+  /// This function currently checks that:
+  /// - Headers and abbreviation tables of individual fit into the section and
+  ///   can be parsed.
----------------
individual `?`


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFVerifier.h:244
+  /// - The CU lists reference existing compile units.
+  /// - The buckets have a valid index, or they are empty
+  ///
----------------
missing `.`


Repository:
  rL LLVM

https://reviews.llvm.org/D44211





More information about the llvm-commits mailing list