[PATCH] D44052: [dsymutil] Unify error handling and add color

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

We might want to think about separating WithColor from the actual syntax definition. Then we could move WithColor to Support, and perhaps have a DWARF syntax definition in a header only in libDebugInfo. Maybe it doesn't matter if it is in support, too, since we already have all the DWARF constants there.

In any case, this seems to be an incremental improvement over the status quo, so it works for me, too.


Repository:
  rL LLVM

https://reviews.llvm.org/D44052