[PATCH] D43819: [ELF] - Restrict section offsets that exceeds file size.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:1832
+    return "<empty range at 0x" + utohexstr(Addr) + ">";
+  return "[0x" + utohexstr(Addr) + " -> 0x" + utohexstr(Addr + Len - 1) + "]";
+}
----------------
grimar wrote:
> jhenderson wrote:
> > ruiu wrote:
> > > `[start -> end]` (e.g. `[0xFFFFFFFF20000000 -> 0xFFFFFFFE40000000]`) is a weird notion to represent a range. I think `[start:end]` is more common.
> > FWIW - this function is just a move of an existing function.
> > 
> > In places like llvm-dwarfdump dumping of debug ranges etc, the common practice is "[start, end)". Maybe that's what we should follow as well.
> Yes. Since it is a move, I would not change the format of the output in this patch.
LLD currently use `[X, Y]` for ranges in the messages:
`relocation R_386_16 out of range: 65536 is not in [0, 65535]`

Should we be consistent here?


https://reviews.llvm.org/D43819