[PATCH] D43850: [CodeGen] Avoid handling DBG_VALUE instructions for stepBackwards

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 18:52:46 PST 2018


mattd updated this revision to Diff 137313.
mattd added a comment.

Thanks for the feedback, and my apologies for not providing additional context in the diff.  The updated patch:

- I added an 'isDebugValue' check to LivePhysRegs::stepForward,  I was hesitant to add this, as it never seemed problematic, but it doesn't seem wrong to add the check here either.
- I made the test a .mir test instead of .ll.  I tried to reduce this as much as possible.


https://reviews.llvm.org/D43850

Files:
  lib/CodeGen/LivePhysRegs.cpp
  test/CodeGen/X86/dbg-changes-codegen-branch-folding2.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43850.137313.patch
Type: text/x-patch
Size: 7411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180307/d4c0e392/attachment.bin>


More information about the llvm-commits mailing list