[PATCH] D27846: [SLP] Support for horizontal min/max reduction

[Sameer AbuAsal via Phabricator via llvm-commits]

sabuasal added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp:5065
+            Instruction::FCmp, LHS, RHS, RK_Max,
+            cast<Instruction>(Select->getCondition())->hasNoNaNs());
+      }
----------------
Hi,

Why are we filling the NonNan flags for the "OperationData" object the value from the condition of the select instruction instead of the select Instruction itself?  Wheb ew get to code gen we check that the value itself is not a Nan, am I missing something?


Repository:
  rL LLVM

https://reviews.llvm.org/D27846