[PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

Aaron Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 17:10:07 PST 2018


asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

https://reviews.llvm.org/D44182

Files:
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp


Index: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
===================================================================
--- source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
+++ source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
@@ -630,9 +630,10 @@
       auto file_extension = file_spec.GetFileNameExtension();
       if (pdb_lang == PDB_Lang::Cpp || pdb_lang == PDB_Lang::C) {
         static const char* exts[] = { "cpp", "c", "cc", "cxx" };
-        if (llvm::is_contained(exts, file_extension.GetStringRef().lower()))
+        if (llvm::is_contained(exts, file_extension.GetStringRef().lower())) {
           source_file_name = file_up->getFileName();
-        break;
+          break;
+        }
       } else if (pdb_lang == PDB_Lang::Masm &&
                  ConstString::Compare(file_extension, ConstString("ASM"),
                                       false) == 0) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44182.137298.patch
Type: text/x-patch
Size: 878 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180307/f5cb084a/attachment.bin>


More information about the llvm-commits mailing list