[PATCH] D44177: [JumpThreading] use InvalidBlocks to avoid unreachable regions

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 16:15:25 PST 2018


brzycki added a comment.

Here are 4 `ctmark` runs on x86_64 of `compile_time` results. The `tip` compiler is llvm-project SHA <https://github.com/llvm-project/llvm-project-20170507> `7a365bd12dd84be1e7c9ca6d9a2268b80f604ae9`. The `upstream` compiler is the same as `tip` with this patch applied.

  # tip (left), upstream (right)
  #  left column: build.tip_ctmark_1/results.json
  # right column: build.upstream_ctmark_1/results.json
  #  metric name: compile_time
      378.3760 -> 346.6120     [  9.16%]  CTMark/sqlite3/sqlite3.test
      499.5760 -> 492.7440     [  1.39%]  CTMark/tramp3d-v4/tramp3d-v4.test
      390.3720 -> 386.4720     [  1.01%]  CTMark/kimwitu++/kc.test
      503.2800 -> 499.5320     [  0.75%]  CTMark/ClamAV/clamscan.test
      253.5440 <- 255.4160     [  0.74%]  CTMark/mafft/pairlocalalign.test
     1272.1440 <- 1279.2400    [  0.56%]  CTMark/7zip/7zip-benchmark.test
      463.2200 -> 461.1600     [  0.45%]  CTMark/SPASS/SPASS.test
      595.7480 <- 597.0600     [  0.22%]  CTMark/lencod/lencod.test
      928.3480 -> 927.5960     [  0.08%]  CTMark/Bullet/bullet.test
      370.5800 -> 370.5160     [  0.02%]  CTMark/consumer-typeset/consumer-typeset.test
  #  left column: build.tip_ctmark_1/results.json
  # right column: build.upstream_ctmark_2/results.json
  #  metric name: compile_time
      499.5760 -> 487.3400     [  2.51%]  CTMark/tramp3d-v4/tramp3d-v4.test
      378.3760 -> 372.8840     [  1.47%]  CTMark/sqlite3/sqlite3.test
      253.5440 -> 250.2840     [  1.30%]  CTMark/mafft/pairlocalalign.test
      390.3720 -> 387.8960     [  0.64%]  CTMark/kimwitu++/kc.test
      595.7480 -> 592.4760     [  0.55%]  CTMark/lencod/lencod.test
      928.3480 <- 931.6960     [  0.36%]  CTMark/Bullet/bullet.test
      370.5800 <- 371.3080     [  0.20%]  CTMark/consumer-typeset/consumer-typeset.test
      503.2800 -> 502.3880     [  0.18%]  CTMark/ClamAV/clamscan.test
     1272.1440 <- 1273.3800    [  0.10%]  CTMark/7zip/7zip-benchmark.test
      463.2200 -> 462.7920     [  0.09%]  CTMark/SPASS/SPASS.test
  #  left column: build.tip_ctmark_1/results.json
  # right column: build.upstream_ctmark_3/results.json
  #  metric name: compile_time
      253.5440 <- 256.0280     [  0.98%]  CTMark/mafft/pairlocalalign.test
      595.7480 -> 591.4720     [  0.72%]  CTMark/lencod/lencod.test
      390.3720 <- 392.2520     [  0.48%]  CTMark/kimwitu++/kc.test
      463.2200 -> 461.2000     [  0.44%]  CTMark/SPASS/SPASS.test
     1272.1440 <- 1275.2320    [  0.24%]  CTMark/7zip/7zip-benchmark.test
      503.2800 -> 502.0800     [  0.24%]  CTMark/ClamAV/clamscan.test
      928.3480 -> 927.0640     [  0.14%]  CTMark/Bullet/bullet.test
      370.5800 <- 371.0080     [  0.12%]  CTMark/consumer-typeset/consumer-typeset.test
      499.5760 -> 499.0160     [  0.11%]  CTMark/tramp3d-v4/tramp3d-v4.test
      378.3760 -> 378.0360     [  0.09%]  CTMark/sqlite3/sqlite3.test
  #  left column: build.tip_ctmark_1/results.json
  # right column: build.upstream_ctmark_4/results.json
  #  metric name: compile_time
      499.5760 <- 541.9040     [  8.47%]  CTMark/tramp3d-v4/tramp3d-v4.test
      378.3760 -> 350.2080     [  8.04%]  CTMark/sqlite3/sqlite3.test
      253.5440 <- 257.6560     [  1.62%]  CTMark/mafft/pairlocalalign.test
      370.5800 -> 365.7360     [  1.32%]  CTMark/consumer-typeset/consumer-typeset.test
      595.7480 -> 590.7960     [  0.84%]  CTMark/lencod/lencod.test
      390.3720 <- 392.9920     [  0.67%]  CTMark/kimwitu++/kc.test
      463.2200 -> 461.2760     [  0.42%]  CTMark/SPASS/SPASS.test
      503.2800 -> 502.0880     [  0.24%]  CTMark/ClamAV/clamscan.test
      928.3480 <- 929.7520     [  0.15%]  CTMark/Bullet/bullet.test
     1272.1440 <- 1273.3720    [  0.10%]  CTMark/7zip/7zip-benchmark.test
  #  left column: build.tip_ctmark_2/results.json
  # right column: build.upstream_ctmark_1/results.json
  #  metric name: compile_time
      587.0520 <- 597.0600     [  1.70%]  CTMark/lencod/lencod.test
      466.3600 -> 461.1600     [  1.13%]  CTMark/SPASS/SPASS.test
      257.6840 -> 255.4160     [  0.89%]  CTMark/mafft/pairlocalalign.test
      496.7760 -> 492.7440     [  0.82%]  CTMark/tramp3d-v4/tramp3d-v4.test
      343.8520 <- 346.6120     [  0.80%]  CTMark/sqlite3/sqlite3.test
      502.8960 -> 499.5320     [  0.67%]  CTMark/ClamAV/clamscan.test
     1275.4080 <- 1279.2400    [  0.30%]  CTMark/7zip/7zip-benchmark.test
      930.1400 -> 927.5960     [  0.27%]  CTMark/Bullet/bullet.test
      369.5240 <- 370.5160     [  0.27%]  CTMark/consumer-typeset/consumer-typeset.test
      387.4960 -> 386.4720     [  0.26%]  CTMark/kimwitu++/kc.test
  #  left column: build.tip_ctmark_2/results.json
  # right column: build.upstream_ctmark_2/results.json
  #  metric name: compile_time
      343.8520 <- 372.8840     [  8.44%]  CTMark/sqlite3/sqlite3.test
      257.6840 -> 250.2840     [  2.96%]  CTMark/mafft/pairlocalalign.test
      496.7760 -> 487.3400     [  1.94%]  CTMark/tramp3d-v4/tramp3d-v4.test
      587.0520 <- 592.4760     [  0.92%]  CTMark/lencod/lencod.test
      466.3600 -> 462.7920     [  0.77%]  CTMark/SPASS/SPASS.test
      369.5240 <- 371.3080     [  0.48%]  CTMark/consumer-typeset/consumer-typeset.test
      930.1400 <- 931.6960     [  0.17%]  CTMark/Bullet/bullet.test
     1275.4080 -> 1273.3800    [  0.16%]  CTMark/7zip/7zip-benchmark.test
      387.4960 <- 387.8960     [  0.10%]  CTMark/kimwitu++/kc.test
      502.8960 -> 502.3880     [  0.10%]  CTMark/ClamAV/clamscan.test
  #  left column: build.tip_ctmark_2/results.json
  # right column: build.upstream_ctmark_3/results.json
  #  metric name: compile_time
      343.8520 <- 378.0360     [  9.94%]  CTMark/sqlite3/sqlite3.test
      387.4960 <- 392.2520     [  1.23%]  CTMark/kimwitu++/kc.test
      466.3600 -> 461.2000     [  1.12%]  CTMark/SPASS/SPASS.test
      587.0520 <- 591.4720     [  0.75%]  CTMark/lencod/lencod.test
      257.6840 -> 256.0280     [  0.65%]  CTMark/mafft/pairlocalalign.test
      496.7760 <- 499.0160     [  0.45%]  CTMark/tramp3d-v4/tramp3d-v4.test
      369.5240 <- 371.0080     [  0.40%]  CTMark/consumer-typeset/consumer-typeset.test
      930.1400 -> 927.0640     [  0.33%]  CTMark/Bullet/bullet.test
      502.8960 -> 502.0800     [  0.16%]  CTMark/ClamAV/clamscan.test
     1275.4080 -> 1275.2320    [  0.01%]  CTMark/7zip/7zip-benchmark.test
  #  left column: build.tip_ctmark_2/results.json
  # right column: build.upstream_ctmark_4/results.json
  #  metric name: compile_time
      496.7760 <- 541.9040     [  9.08%]  CTMark/tramp3d-v4/tramp3d-v4.test
      343.8520 <- 350.2080     [  1.85%]  CTMark/sqlite3/sqlite3.test
      387.4960 <- 392.9920     [  1.42%]  CTMark/kimwitu++/kc.test
      466.3600 -> 461.2760     [  1.10%]  CTMark/SPASS/SPASS.test
      369.5240 -> 365.7360     [  1.04%]  CTMark/consumer-typeset/consumer-typeset.test
      587.0520 <- 590.7960     [  0.64%]  CTMark/lencod/lencod.test
      502.8960 -> 502.0880     [  0.16%]  CTMark/ClamAV/clamscan.test
     1275.4080 -> 1273.3720    [  0.16%]  CTMark/7zip/7zip-benchmark.test
      930.1400 -> 929.7520     [  0.04%]  CTMark/Bullet/bullet.test
      257.6840 -> 257.6560     [  0.01%]  CTMark/mafft/pairlocalalign.test
  #  left column: build.tip_ctmark_3/results.json
  # right column: build.upstream_ctmark_1/results.json
  #  metric name: compile_time
      540.9680 -> 492.7440     [  9.79%]  CTMark/tramp3d-v4/tramp3d-v4.test
      357.0480 -> 346.6120     [  3.01%]  CTMark/sqlite3/sqlite3.test
      589.7160 <- 597.0600     [  1.25%]  CTMark/lencod/lencod.test
      366.6280 <- 370.5160     [  1.06%]  CTMark/consumer-typeset/consumer-typeset.test
      257.4080 -> 255.4160     [  0.78%]  CTMark/mafft/pairlocalalign.test
      502.8920 -> 499.5320     [  0.67%]  CTMark/ClamAV/clamscan.test
      388.6480 -> 386.4720     [  0.56%]  CTMark/kimwitu++/kc.test
      930.4400 -> 927.5960     [  0.31%]  CTMark/Bullet/bullet.test
     1277.1600 <- 1279.2400    [  0.16%]  CTMark/7zip/7zip-benchmark.test
      460.5200 <- 461.1600     [  0.14%]  CTMark/SPASS/SPASS.test
  #  left column: build.tip_ctmark_3/results.json
  # right column: build.upstream_ctmark_2/results.json
  #  metric name: compile_time
      540.9680 -> 487.3400     [ 11.00%]  CTMark/tramp3d-v4/tramp3d-v4.test
      357.0480 <- 372.8840     [  4.44%]  CTMark/sqlite3/sqlite3.test
      257.4080 -> 250.2840     [  2.85%]  CTMark/mafft/pairlocalalign.test
      366.6280 <- 371.3080     [  1.28%]  CTMark/consumer-typeset/consumer-typeset.test
      460.5200 <- 462.7920     [  0.49%]  CTMark/SPASS/SPASS.test
      589.7160 <- 592.4760     [  0.47%]  CTMark/lencod/lencod.test
     1277.1600 -> 1273.3800    [  0.30%]  CTMark/7zip/7zip-benchmark.test
      388.6480 -> 387.8960     [  0.19%]  CTMark/kimwitu++/kc.test
      930.4400 <- 931.6960     [  0.13%]  CTMark/Bullet/bullet.test
      502.8920 -> 502.3880     [  0.10%]  CTMark/ClamAV/clamscan.test
  #  left column: build.tip_ctmark_3/results.json
  # right column: build.upstream_ctmark_3/results.json
  #  metric name: compile_time
      540.9680 -> 499.0160     [  8.41%]  CTMark/tramp3d-v4/tramp3d-v4.test
      357.0480 <- 378.0360     [  5.88%]  CTMark/sqlite3/sqlite3.test
      366.6280 <- 371.0080     [  1.19%]  CTMark/consumer-typeset/consumer-typeset.test
      388.6480 <- 392.2520     [  0.93%]  CTMark/kimwitu++/kc.test
      257.4080 -> 256.0280     [  0.54%]  CTMark/mafft/pairlocalalign.test
      930.4400 -> 927.0640     [  0.36%]  CTMark/Bullet/bullet.test
      589.7160 <- 591.4720     [  0.30%]  CTMark/lencod/lencod.test
      502.8920 -> 502.0800     [  0.16%]  CTMark/ClamAV/clamscan.test
     1277.1600 -> 1275.2320    [  0.15%]  CTMark/7zip/7zip-benchmark.test
      460.5200 <- 461.2000     [  0.15%]  CTMark/SPASS/SPASS.test
  #  left column: build.tip_ctmark_3/results.json
  # right column: build.upstream_ctmark_4/results.json
  #  metric name: compile_time
      357.0480 -> 350.2080     [  1.95%]  CTMark/sqlite3/sqlite3.test
      388.6480 <- 392.9920     [  1.12%]  CTMark/kimwitu++/kc.test
     1277.1600 -> 1273.3720    [  0.30%]  CTMark/7zip/7zip-benchmark.test
      366.6280 -> 365.7360     [  0.24%]  CTMark/consumer-typeset/consumer-typeset.test
      589.7160 <- 590.7960     [  0.18%]  CTMark/lencod/lencod.test
      540.9680 <- 541.9040     [  0.17%]  CTMark/tramp3d-v4/tramp3d-v4.test
      460.5200 <- 461.2760     [  0.16%]  CTMark/SPASS/SPASS.test
      502.8920 -> 502.0880     [  0.16%]  CTMark/ClamAV/clamscan.test
      257.4080 <- 257.6560     [  0.10%]  CTMark/mafft/pairlocalalign.test
      930.4400 -> 929.7520     [  0.07%]  CTMark/Bullet/bullet.test
  #  left column: build.tip_ctmark_4/results.json
  # right column: build.upstream_ctmark_1/results.json
  #  metric name: compile_time
      351.1320 -> 346.6120     [  1.30%]  CTMark/sqlite3/sqlite3.test
      486.5040 <- 492.7440     [  1.28%]  CTMark/tramp3d-v4/tramp3d-v4.test
      253.6800 <- 255.4160     [  0.68%]  CTMark/mafft/pairlocalalign.test
      464.2840 -> 461.1600     [  0.68%]  CTMark/SPASS/SPASS.test
     1275.1200 <- 1279.2400    [  0.32%]  CTMark/7zip/7zip-benchmark.test
      595.3080 <- 597.0600     [  0.29%]  CTMark/lencod/lencod.test
      387.2880 -> 386.4720     [  0.21%]  CTMark/kimwitu++/kc.test
      500.5120 -> 499.5320     [  0.20%]  CTMark/ClamAV/clamscan.test
      369.8800 <- 370.5160     [  0.17%]  CTMark/consumer-typeset/consumer-typeset.test
      926.4040 <- 927.5960     [  0.13%]  CTMark/Bullet/bullet.test
  #  left column: build.tip_ctmark_4/results.json
  # right column: build.upstream_ctmark_2/results.json
  #  metric name: compile_time
      351.1320 <- 372.8840     [  6.19%]  CTMark/sqlite3/sqlite3.test
      253.6800 -> 250.2840     [  1.36%]  CTMark/mafft/pairlocalalign.test
      926.4040 <- 931.6960     [  0.57%]  CTMark/Bullet/bullet.test
      595.3080 -> 592.4760     [  0.48%]  CTMark/lencod/lencod.test
      369.8800 <- 371.3080     [  0.39%]  CTMark/consumer-typeset/consumer-typeset.test
      500.5120 <- 502.3880     [  0.37%]  CTMark/ClamAV/clamscan.test
      464.2840 -> 462.7920     [  0.32%]  CTMark/SPASS/SPASS.test
      486.5040 <- 487.3400     [  0.17%]  CTMark/tramp3d-v4/tramp3d-v4.test
      387.2880 <- 387.8960     [  0.16%]  CTMark/kimwitu++/kc.test
     1275.1200 -> 1273.3800    [  0.14%]  CTMark/7zip/7zip-benchmark.test
  #  left column: build.tip_ctmark_4/results.json
  # right column: build.upstream_ctmark_3/results.json
  #  metric name: compile_time
      351.1320 <- 378.0360     [  7.66%]  CTMark/sqlite3/sqlite3.test
      486.5040 <- 499.0160     [  2.57%]  CTMark/tramp3d-v4/tramp3d-v4.test
      387.2880 <- 392.2520     [  1.28%]  CTMark/kimwitu++/kc.test
      253.6800 <- 256.0280     [  0.93%]  CTMark/mafft/pairlocalalign.test
      464.2840 -> 461.2000     [  0.67%]  CTMark/SPASS/SPASS.test
      595.3080 -> 591.4720     [  0.65%]  CTMark/lencod/lencod.test
      500.5120 <- 502.0800     [  0.31%]  CTMark/ClamAV/clamscan.test
      369.8800 <- 371.0080     [  0.30%]  CTMark/consumer-typeset/consumer-typeset.test
      926.4040 <- 927.0640     [  0.07%]  CTMark/Bullet/bullet.test
     1275.1200 <- 1275.2320    [  0.01%]  CTMark/7zip/7zip-benchmark.test
  #  left column: build.tip_ctmark_4/results.json
  # right column: build.upstream_ctmark_4/results.json
  #  metric name: compile_time
      486.5040 <- 541.9040     [ 11.39%]  CTMark/tramp3d-v4/tramp3d-v4.test
      253.6800 <- 257.6560     [  1.57%]  CTMark/mafft/pairlocalalign.test
      387.2880 <- 392.9920     [  1.47%]  CTMark/kimwitu++/kc.test
      369.8800 -> 365.7360     [  1.13%]  CTMark/consumer-typeset/consumer-typeset.test
      595.3080 -> 590.7960     [  0.76%]  CTMark/lencod/lencod.test
      464.2840 -> 461.2760     [  0.65%]  CTMark/SPASS/SPASS.test
      926.4040 <- 929.7520     [  0.36%]  CTMark/Bullet/bullet.test
      500.5120 <- 502.0880     [  0.31%]  CTMark/ClamAV/clamscan.test
      351.1320 -> 350.2080     [  0.26%]  CTMark/sqlite3/sqlite3.test
     1275.1200 -> 1273.3720    [  0.14%]  CTMark/7zip/7zip-benchmark.test


Repository:
  rL LLVM

https://reviews.llvm.org/D44177





More information about the llvm-commits mailing list