[PATCH] D44125: [sanitizer] Move mmap interceptors into sanitizer_common

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 14:59:25 PST 2018


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc:277
+    if (res != (void *)-1 && common_flags()->intercept_intrin)             \
+      COMMON_INTERCEPTOR_WRITE_RANGE(ctx, res, sz);                        \
+    return res;                                                            \
----------------
morehouse wrote:
> Does it make sense to call `COMMON_INTERCEPTOR_WRITE_RANGE` at all?  Doesn't `mmap` just create a mapping rather than writing to memory?
sure, we don't need this.


https://reviews.llvm.org/D44125





More information about the llvm-commits mailing list