[PATCH] D44150: [WebAssembly] Move WasmSignatureDenseMapInfo to header for reuse. NFC

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 14:37:41 PST 2018


On Tue, Mar 6, 2018 at 2:36 PM Sam Clegg via Phabricator <
reviews at reviews.llvm.org> wrote:

> sbc100 added a comment.
>
> I'm not sure about putting this stuff in the BinaryFormat.   To me it
> makes sense to keep those headers as mostly structures and enums.  If its
> just a matter of having this in two places I don't think that a huge deal
> (although the one in llvm is missing a recent fix which argues against my
> point :)
>

Maybe. It's not a big deal to have this in two places, so it is up to you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180306/0982ebcf/attachment.html>


More information about the llvm-commits mailing list