[PATCH] D44150: [WebAssembly] Move WasmSignatureDenseMapInfo to header for reuse. NFC

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 11:41:28 PST 2018


sbc100 added a comment.

I'll defer to @ruiu but seems good to me.



================
Comment at: wasm/Writer.cpp:122
   std::vector<const WasmSignature *> Types;
-  DenseMap<WasmSignature, int32_t, WasmSignatureDenseMapInfo> TypeIndices;
   std::vector<const Symbol *> ImportedSymbols;
----------------
Interesting.  Is this the preferred way to do this?   Seems better I guess.

@ruiu, you know more about the llvm ADT stuff than me.  Is this how it should have been from the beginning?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44150





More information about the llvm-commits mailing list