[PATCH] D43219: [PartialInlining] Fix Crash from holding a reference to a destructed ORE

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 11:32:37 PST 2018


sfertile added a reviewer: gman000.
sfertile added a subscriber: graham-yiu-huawei.
sfertile added a comment.

Are there any though on this? I would really appreciate feedback since I'm not very familiar with either the new-pass-manager or the OptimizationRemarkEmitter.  One thing I'm unclear on is if there is some limitation forcing us to get a OptimizationRemarkEmitterAnalysis from the FunctionAnalysisManager.  If that's not a hard limitation and we can simply create the OREs  when needed then ends up pretty trivial to fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D43219





More information about the llvm-commits mailing list