[PATCH] D38792: Fix float literals under XO & fp-armv8

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 06:03:32 PST 2018


SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:5682
     } else {
-      return DAG.getConstant(INTVal, DL, MVT::i32);
+      assert(VT == MVT::f32);
+      // leave the constant if target can address it as an immediate.
----------------
Sorry to be a bit of a pain here, but I think that after my FP16 changes went in, we can also expect f16 values here. But hopefully that does not changes much; looks like only thing is that instead of a VMOVSR, we need a VMOVHR (and a test).


Repository:
  rL LLVM

https://reviews.llvm.org/D38792





More information about the llvm-commits mailing list