[PATCH] D25987: [X86] New pattern to generate PSUBUS from SELECT

Yulia Koval via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 04:27:30 PST 2018


yulia_koval added a comment.

In https://reviews.llvm.org/D25987#1005390, @spatel wrote:

> Did https://reviews.llvm.org/D41480 affect anything with these tests? We still need to handle 'umin' patterns in IR and update the tests here with canonical IR forms to show psubus codegen?


Looks like all possible umin patterns are already handled in existing patterns we added for max. The last tests in psubus.ll is also cannonical cmp-select-sub sequence. What should I add which is missing?


https://reviews.llvm.org/D25987





More information about the llvm-commits mailing list