[PATCH] D43313: [DebugInfo] Support parsing DWARF expressions

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 15:41:45 PST 2018


rafauler added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:33
+  /// Types of operands to CFI instructions.
+  enum OperandType {
+    OT_Unset,
----------------
JDevlieghere wrote:
> Should this go in `Dwarf.def`?
This OperandType stuff is not from DWARF specs, but this is a custom thing from our implementation created just to simplify instruction printing. I've moved this to  "private" because this really shouldn't be exported, and I also enhanced the comments to better explain this enum.


Repository:
  rL LLVM

https://reviews.llvm.org/D43313





More information about the llvm-commits mailing list