[PATCH] D44085: MSan, FreeBSD few tests fixes

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 05:15:45 PST 2018


devnexen added inline comments.


================
Comment at: test/msan/pthread_getattr_np_deadlock.cc:13
   pthread_attr_t attr;
+#if !defined(__FreeBSD__)
   int res = pthread_getattr_np(pthread_self(), &attr);
----------------
krytarowski wrote:
> Can we go without negation? `#if defined(__FreeBSD__)`?
I just do not dare to put FreeBSD in "first" otherwise I have no problem to do the other way around.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44085





More information about the llvm-commits mailing list