[PATCH] D44085: MSan, FreeBSD few tests fixes

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 04:39:19 PST 2018


krytarowski added a subscriber: eugenis.
krytarowski added inline comments.


================
Comment at: test/msan/pthread_getattr_np_deadlock.cc:13
   pthread_attr_t attr;
+#if !defined(__FreeBSD__)
   int res = pthread_getattr_np(pthread_self(), &attr);
----------------
Can we go without negation? `#if defined(__FreeBSD__)`?


================
Comment at: test/msan/pthread_getname_np.cc:3
+// The main goal is getting the pthread name back and libc
+// *BSD based do not support this feature
+// UNSUPPORTED: android, netbsd, freebsd
----------------
There is `pthread_getname_np` and `pthread_setname_np` on NetBSD. 

It looks like it was added by @eugenis and I still have not fixed it.

Please don't use `*BSD` wildcard as these systems have little in share in 2018.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44085





More information about the llvm-commits mailing list