[PATCH] D43468: [ELF] - Support "INSERT AFTER" statement.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 04:02:51 PST 2018


grimar added inline comments.


================
Comment at: test/ELF/insert-after.s:4-14
+# RUN: echo "SECTIONS {               \
+# RUN:   .foo.data : { *(.foo.data) } \
+# RUN:  } INSERT AFTER .data;         \
+# RUN:  SECTIONS {                    \
+# RUN:   .foo.text : { *(.foo.text) } \
+# RUN:  } INSERT AFTER .text;" > %tinsert.script
+
----------------
grimar wrote:
> ruiu wrote:
> > We should stop writing linker scripts using "echo". As I did, rewrite this file as a linker script. You could create Inputs/insert-after.s.
> This patch was posted a few weeks before your change :) I'll update it.
Also, note there are 2 linker scripts required here.


https://reviews.llvm.org/D43468





More information about the llvm-commits mailing list