[PATCH] D44002: [test] Add dotest wrapper
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 3 11:10:37 PST 2018
davide accepted this revision.
davide added a comment.
In https://reviews.llvm.org/D44002#1025573, @labath wrote:
> In https://reviews.llvm.org/D44002#1025558, @aprantl wrote:
> > We could take this even one step further, by either elevating the big categories (dwarf, dsym, dwo) on the same level as the compiler choice (e.g., run the testsuite for (clang-6.0, dwo)), *or* by sinking the compiler choice into test matrix inside of dotest (basically dotest would accept a list of compilers).
> At one point in the past, dotest accepted a list of compilers and architectures and then ran each test for the cartesian product. However, this was broken for a long time (it operated on a completely different level than the debug flavour thingy) and so it was removed.
That's a good thing. I'm really not in favor of having this cartesian explosion. If people want to run multiple configuration, then it needs to happen in some principled manner (if anything, the cmdline should be generated by a textual configuration representation, YAML or JSON or something else).
About the patch itself, LGTM. I wonder whether we should call the binary `lldb-dotest`. But I don't feel really strong about it, so go for whatever you like.
More information about the llvm-commits