[PATCH] D44050: OpenBSD UBsan support procmaps

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 3 07:10:39 PST 2018


krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:99
 #endif  // SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_NETBSD ||
         // SANITIZER_MAC || SANITIZER_SOLARIS
 #endif  // SANITIZER_PROCMAPS_H
----------------
Missing OPENBSD


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_common.cc:173
 
 #endif // SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD ||
        // SANITIZER_SOLARIS
----------------
Missing OPENBSD


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_freebsd.cc:56
+    getpid()
 #else
     CTL_VM,
----------------
while there, `#elif SANITIZER_NETBSD` followed by `#else` `#error not supported`


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44050





More information about the llvm-commits mailing list