[PATCH] D44057: [SimplifyCFG] Create attribute to disable simplifyCFG.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 19:34:21 PST 2018


arsenm added a comment.

In https://reviews.llvm.org/D44057#1026419, @arsenm wrote:

> I think the concept of an attribute to specially disable a specific pass is concerning. This is actually more aggressive since it will also disable it if a pass attempts to use the utility function on a specific block


More specifically I think if a pass wants to call simplifyCFG the utility function, it should be able to rely on some of the expected canonicalizations so it would not be OK for anything to just disable this


https://reviews.llvm.org/D44057





More information about the llvm-commits mailing list