[PATCH] D44048: [DebugInfo] Add DW_AT_byte_size to vectors

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Minor comments inline, but otherwise this seems reasonable. Thanks!



================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1426
+  assert(Elements.size() == 1 &&
+         Elements[0]->getTag() == dwarf::DW_TAG_subrange_type);
+  const auto Subrange = cast<DISubrange>(Elements[0]);
----------------
Could you add `&& "not a subrange"` and make sure that the Verifier complains when this condition isn't met?


https://reviews.llvm.org/D44048