[PATCH] D44052: [dsymutil] Unify error handling and add color

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, davide.
Herald added a subscriber: hiraditya.

We improved the handling of errors and warnings in dwarfdump's verifier in
https://reviews.llvm.org/rL314498. This patch does the same thing for dsymutil.

I moved the SyntaxHighlighting header out of `libDwarf`. I'm not sure
whether it would make sense to move this in support, as the syntax
itself is still pretty much tailored to dumping debug info. Putting it
in the DebugInfo root also didn't feel right, so this felt like the
least invasive thing to do for now. Please don't hesitate to let me know
if you have a better alternative in mind!


Repository:
  rL LLVM

https://reviews.llvm.org/D44052

Files:
  llvm/include/llvm/DebugInfo/DWARF/SyntaxHighlighting.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/lib/DebugInfo/DWARF/SyntaxHighlighting.cpp
  llvm/lib/DebugInfo/DWARF/SyntaxHighlighting.h
  llvm/test/tools/dsymutil/X86/module-warnings.test
  llvm/test/tools/dsymutil/X86/swift-ast-x86_64.test
  llvm/tools/dsymutil/DwarfLinker.cpp
  llvm/tools/dsymutil/dsymutil.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44052.136876.patch
Type: text/x-patch
Size: 11055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180303/28058760/attachment.bin>