[PATCH] D44036: OpenBSD UBsan support / common part 3

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 14:39:03 PST 2018

devnexen added inline comments.

Comment at: lib/sanitizer_common/sanitizer_linux.cc:91
+#include <sys/thr.h>
 extern char **environ;  // provided by crt1
vitalybuka wrote:
> why do you need sys/thr.h here?
Because of thr_self

Comment at: lib/sanitizer_common/sanitizer_linux.cc:319
-  return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path,
+  return internal_syscall_ptr(SYSCALL(newfstatat), AT_FDCWD, (uptr)path,
                           (uptr)buf, 0);
vitalybuka wrote:
> why _ptr was added here and to other non OPENBSD parts?
@kamil asked me for Linux since internal_syscall_ptr = internal_syscall

  rCRT Compiler Runtime


More information about the llvm-commits mailing list