[PATCH] D43934: [ELF] - Report location for div/mod by zero.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 13:35:14 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/ScriptParser.cpp:808
+    std::string Loc = getCurrentLocation();
+    return [=] {
+      if (uint64_t RV = R().getValue())
----------------
nit: my preference is to use `-> uint64_t` instead of type casting a return value.


https://reviews.llvm.org/D43934





More information about the llvm-commits mailing list