[PATCH] D42960: [ELF] DEMO: Example for adding .eh_frame pieces to map file
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 13:31:42 PST 2018
ruiu added a comment.
Feature-wise this is OK but the code doesn't seem to fit well to other code in lld. Please read other part of the code and make your new code similar to that. In particular, please
- make functions shorter
- don't use `auto` and
- simplify code and logic.
More information about the llvm-commits