[PATCH] D43468: [ELF] - Support "INSERT AFTER" statement.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 12:58:29 PST 2018


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> +  // Now when we read all script files, we want to finalize order of linker
> +  // script commands, which can be not yet final because of INSERT commands.
> +  Script->processInsertCommands();

Gramar fixes:

Now that we read ...
commands, which might not yet be final ...

I think this patch is OK since the implementation is a direct
translation of the spec.

Emmanuel, can you confirm that this patch works for you?

LGTM if the patch is found to work with the original scripts.

Thanks,
Rafael


More information about the llvm-commits mailing list