[PATCH] D43644: Make llvm::djbHash an inline function.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 12:55:44 PST 2018


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Sorry, I missed this one, I'll have to configure my email filters better.



================
Comment at: llvm/lib/Support/DJB.cpp:22-24
-static inline uint32_t djbHashChar(unsigned char C, uint32_t H) {
-  return (H << 5) + H + C;
-}
----------------
It may be better to put this in the header as well (perhaps in a detail namespace) so you don't have to manually inline it below, but that's just splitting hairs. I am fine with this option as well.


https://reviews.llvm.org/D43644





More information about the llvm-commits mailing list