[PATCH] D43620: [Pipeliner] Fixed node order issue related to zero latency edges

[Jan-Willem Roorda via Phabricator via llvm-commits]

jwroorda marked an inline comment as done.
jwroorda added inline comments.


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:937
+  // check for node order issues
+  bool ValidNodeOrder = isValidNodeOrder(Circuits);
+
----------------
bcahoon wrote:
> Should this call be moved to the DEBUG statement below? If the compiler is built without asserts, then this will generate a warning/error due to an unused variable.
I see your point. However, if the call is moved inside the DEBUG statement, the statistics information is only updated when debug information is printed. Therefore, instead, I moved the printing of "Invalid node order found!" inside the checkValidNodeOrder function.



https://reviews.llvm.org/D43620