[PATCH] D43729: [CallSiteSplitting] properly split musttail calls

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Great thanks! LGTM. Just 2 small nits that can be addressed before committing, without additional review



================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:303
+  // `musttail` calls must be followed by optional `bitcast`, and `ret`. The
+  // split blokcs will be terminated right after that so there're no users for
+  // this phi in a `TailBB`.
----------------
blokcs -> blocks


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:353
+    // Remove superfluous `br` terminators from the end of the Split blocks
+    for (unsigned i = 0; i < Splits.size(); i++)
+      Splits[i]->getTerminator()->eraseFromParent();
----------------
range based for loop?


https://reviews.llvm.org/D43729