[PATCH] D43901: Make STATISTIC() values available programmatically

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 10:56:30 PST 2018

rtereshin added a comment.

Thanks! That's looking great!

As discussed, a separate patch could add a lock on that mutex in PrintStatistics and PrintStatisticsJSON to avoid the race.

I'm amazed that C++ standard library doesn't appear to have a Writer/Reader Lock, only the regular mutex. That's a shame. That thing could be useful here.

LGTM (again =))



More information about the llvm-commits mailing list