[PATCH] D43978: Write a hash of the binary as the PE Debug Directory Timestamp

[Zachary Turner via llvm-commits]

Yea I guess the Age field would change, nothing else. Forgot about that.
Maybe that’s sufficient, I’ll confirm today and send to bruce for
experiments
On Fri, Mar 2, 2018 at 7:26 AM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> In https://reviews.llvm.org/D43978#1025330, @thakis wrote:
>
> > In https://reviews.llvm.org/D43978#1024821, @zturner wrote:
> >
> > > Apparently this *still* isn't quite right.  The scenario presented to
> me was this:
> > >
> > > 1. User does a clean build, hash X gets written into PDB, hash Y gets
> written into EXE.
> > > 2. User archives EXE and PDB on symbol store.  EXE is in some
> directory X, PDB is in some directory Y.
> > > 3. User adds some blank lines and rebuilds.  EXE doesn't change but
> PDB does.
> > > 4. User re-archives.  EXE is unchanged so doesn't get updated on the
> symbol store, but PDB does.  PDB now gets archived in directory Z.
> > >
> > >   So now there is only one EXE, Y, but there are two PDBs, X and Z.
> If you have the new source code, you will run the EXE, it will find it
> under directory Y in the sym store, map to the old PDB X, and the source
> won't match.
> >
> >
> > I don't understand this scenario. If the pdb changes, doesn't the RSDS
> header in the exe linking to the binary have to change as well?
>
>
> Sorry, the RSDS header in the exe linking it to the _pdb_...
>
>
> https://reviews.llvm.org/D43978
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180302/e753cf9b/attachment.html>