[PATCH] D43991: [WebAssembly] More uses of uint8_t for single byte values

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 05:24:53 PST 2018


ncw added a comment.

In https://reviews.llvm.org/D43991#1025115, @aheejin wrote:

> This broke `test/MC/WebAssembly/global-ctor-dtor.ll` in the waterfall <https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.wasm.llvm%2Flinux%2F29615%2F%2B%2Frecipes%2Fsteps%2FLLVM_regression_tests%2F0%2Fstdout>. I checked the output but don't have any idea why it's causing differences in relocation and function information (I'm not familiar with the linker). Do you know why?


The relocs were changing because the operand went from `0x40` (correct value) to `0xC000` (SLEB encoding of 0x40). Because the length of the sequence changed, the addresses of all the relocs were shifted.


Repository:
  rL LLVM

https://reviews.llvm.org/D43991





More information about the llvm-commits mailing list