[PATCH] D43966: [WebAssembly] Simplify COMDAT handling.

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 01:35:13 PST 2018

ncw added a comment.

In https://reviews.llvm.org/D43966#1024468, @ruiu wrote:

> I think that's a right direction, though that should be done as a separate patch after this.
> Your change needs to change llvm/lib/Object/WasmObjectFile.cpp right? One thing I noticed there is that WasmObjectFile::parseLinkingSectionComdat does an expensive test using a set. I don't think that's we want check for name uniqueness in WasmObjectFile.cpp, as it should be a lightweight wrapper to read object files as quickly as possible.

Good point, I can look into getting rid of that at the same time, when I get to submitting that patch.

By the way, I didn't mean to be rude, my last comment might have sounded like "I've done this already and my way's better". I just meant to say what I was working on, for comparison. I think it's great by the way you're working on Wasm-LLD; when Wasm came along was it maybe someone else's idea/initiative? It's good of you to make time in your schedule to work on the Wasm toolchain if you're not using it yourself!



More information about the llvm-commits mailing list