[PATCH] D43981: [XRay] [compiler-rt] [macosx] Add getTSCFrequency implementation for macOS.

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 17:22:07 PST 2018


kubamracek added inline comments.


================
Comment at: lib/xray/xray_x86_64.cc:107
+    currentTime /= TimebaseInfo.denom;
+    return currentTime;
+}
----------------
Why are we returning "current time" when the function is supposed to return "TSC frequency"? How is a current timestamp a frequency value?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43981





More information about the llvm-commits mailing list