[PATCH] D43987: Fix ar command line expansion on Windows.

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 17:15:31 PST 2018

Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.

This is good, but this should be using llvm-ar's `failIfError` instead of adding `ExitOnError`. Moving the error handling to `ExitOnError` should be a separate commit if done.

Really all of our tools should be doing this, as it also (mostly) properly handles unicode paths on Windows.


More information about the llvm-commits mailing list