[PATCH] D43920: Set DF_TEXTREL instead of creating an empty DT_TEXTREL.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 14:35:10 PST 2018


On Thu, Mar 1, 2018 at 2:34 PM Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama <ruiu at google.com> writes:
>
> > On Thu, Mar 1, 2018 at 2:19 PM Rafael Avila de Espindola <
> > rafael.espindola at gmail.com> wrote:
> >
> >> Sigh, looks like DF_TEXTREL is also missing from musl.
> >>
> >> Maybe we could decide on DF_TEXTREL or DT_TEXTREL based on
> >> -enable-new-dtags?
> >>
> >
> > Hmm, I could, but I'd just do both then for the sake of simplicity.
>
> Having it based on -enable-new-dtags would be a way of putting some
> pressure to move to the new flag.
>

I'd agree -- and we can make --enable-new-dtags default.


> In any case, I am OK with having both.
>
> Taking a look at the implementation proper.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180301/daad581d/attachment-0001.html>


More information about the llvm-commits mailing list