[PATCH] D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

I was just speaking to @jgravelle-google about this issue.  I think we are leaning towards just leaving the status quo is that maybe we should just leave the status quo.  The only downside is that we will need to produce an error if somebody tries to export a symbol called `memory`.  Given that we want to recommend limiting the number of exports (i.e. hidden is the default in for our clang generated symbols) this doesn't seems like a big risk/cost.

We figured that all embedding/hosting code will probably want easy access to this object so giving it a more obscure name seems unnecessarily complicated.  We also have existing users in the form of emscripten and wasm.js (and possibly others) which would all need to updated.

I guess we will want the error message in any case (even if we rename this).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43675