[PATCH] D43288: [AArch64] Add support for secrel add/load/store relocations for COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64MCExpr.h:38-39
     VK_TLSDESC  = 0x007,
-    VK_SymLocBits = 0x00f,
+    VK_SECREL   = 0x200,
+    VK_SymLocBits = 0x20f,
 
----------------
rnk wrote:
> VariantKind has 32 bits. It's probably cleaner to move the VK_AddressFragBits over to 0xf00 and VK_NC to 0x1000 and give ourselves 8 bits for symbol locations.
Actually, I don't know what I was thinking here, I could just make VK_SECREL = 0x008 which fits within the existing mask as well. Will commit with that simplification.


https://reviews.llvm.org/D43288